Re: Review and Suggestions - My First Module

[tcf03]

I do something similar but have a sub for each type of DB - often times you need to set environmental vars, or some databases require different information passed ( or not ).

sub MSSQLConnect
{
    my $ds        = shift;
    my $db        = shift;
    my $user      = shift;
    my $pass      = shift;
    
    $ENV{SYBASE}  = '/usr/local';
    $ENV{DSQUERY} = $ds;
    
    my $dbh = DBI->connect("dbi:Sybase:database=$db",
                      $user, $pass ) or
                     return "Unable to connext to $ds: $!";
    return $dbh;
}

sub INFORMIXConnect
{
    my $server = shift;
    my $db = shift;
    #my $user   = shift;
    #my $pass   = shift;
        
    $ENV{INFORMIXSERVER} = $server;
    $ENV{ONCONFIG}       = "${server}.onconfig";
    $ENV{INFORMIXDIR}    = '/opt/informix';
    #$ENV{DBDATE}        = 'MDY4-';
    #$ENV{DBTIME}        = '%I:%M:%S';
    $ENV{PATH}           = '/usr/local/bin:/usr/bin:/bin:$ENV{INFORMIX
+DIR}/bin';
    
    my $dsn = "dbi:Informix:$db";
    my $dbh = DBI->connect("$dsn") or #, $user, $pass) or
                return "Unable to connect to $server: $!\n";
    
    return $dbh;
}