Beefy Boxes and Bandwidth Generously Provided by pair Networks
Clear questions and runnable code
get the best and fastest answer
 
PerlMonks  

Re^3: Ignorance Isnt Always Bliss

by GrandFather (Saint)
on Feb 12, 2008 at 04:33 UTC ( [id://667503]=note: print w/replies, xml ) Need Help??


in reply to Re^2: Ignorance Isnt Always Bliss
in thread Ignorance Isnt Always Bliss

After applying PerlTidy the following looks interesting:

open THEFILE, "$config{'basepath'}$key/$file"; my ( $title, $reserve, $inc, $desc, $image1, $image2, $image3, $image4, $thumb1, $thumb2, $thumb3, $thumb4, $dutch, $qty, $bold, $highlight, $feat, $catfeat, $grabber, $relist, $buyit, $gallery, $counter, $ship1, $ship2, $ship3, $ship4, $ship5, $shipcost, $location, $pay1, $pay2, $pay3, $pay4, $pay5, $pay6, $pay7, $pay8, $pay9, $paypal, $idata1, $idata2, $idata3, $idata4, $idata5, $idata6, $idata7, $idata8, $idata9, @bids ) = <THEFILE>; my ( $alias, $email, $bid, $time, $add1, $add2, $add3, $oqty, $qtysold ) = &read_bid ($bids[$#bids]);

Notice that @bids is set by reading a file (my (..., @bids) = <THEFILE>) and that then, without any checking at all, the presumed to exist last element is accessed. If there are too few lines in the input file then the 'last element access' will fail.

Looks to me like there is far too much string and bubble gum involved in holding this system together!


Perl is environmentally friendly - it saves trees

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://667503]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others goofing around in the Monastery: (4)
As of 2024-03-29 01:41 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found