A Warning Issue!

[Anonymous Monk]

Hi Monks!

I have this code as part of my program generating "Use of un initialized value in pattern match (m//)", could this be because of the empty "IF" is its true?
I already initialized the variables for the regular expression to avoid the warning, Am I initializing these variables wrong?
How can I avoid the warning?!

Sample code:

my @list = ();
my $lastc_33 = '';
my $lastd_34='';
my $last_33='';

......

if( $_->{ TEST33 } eq $lastc_33 && $lastd_34 =~/8/ && $last_33 =~/00/ 
+&& $_->{ TEST34 } =~/7/ && $_->{ TEST33 } =~/00/ )  {

}
else  {
          $lastd_34 = $_->{ TEST34 };
          $last_33 = $_->{ TEST33 };
          push (@list, $_);
       }

Thank you!!!

[jrsimmon]

I strongly suspect that the uninit'd var perl is complaining about is $_->{TEST34}. I suggest checking your vars to be sure.

use Data::Dumper;

my @list = ();
my $lastc_33 = '';
my $lastd_34='';
my $last_33='';

......
print Dumper $_->{TEST33};
print Dumper $lastc_33;
print Dumper $lastd_34;
print Dumper $last_33;
print Dumper $_->{TEST34};


if( $_->{ TEST33 } eq $lastc_33 && $lastd_34 =~/8/ && $last_33 =~/00/ 
+&& $_->{ TEST34 } =~/7/ && $_->{ TEST33 } =~/00/ )  {

}
else  {
          $lastd_34 = $_->{ TEST34 };
          $last_33 = $_->{ TEST33 };
          push (@list, $_);
       }

If that still doesn't show you where the warning is being generated, break up your if statement so that you can see which piece of it is generating the error.

[thezip]

Since you've explicitly initialized a few of the variables, then only the remaining ones are the potential causes for the warnings, namely $_->{ TEST34 } and $_->{ TEST33 }.

Perhaps you might want to check their values prior to the IF statement to ensure they are what you think they are. If either is not initialized, then just don't execute the IF statement.

BTW, that's a fairly complicated piece of logic there. Maybe you might want to break it up into smaller, logical chunks? That way, you'll have a better idea of what you were trying to do six months down the road.

[Anonymous Monk]

That's why I am confused, I my head the IF should be doing this check, how would I check otherwise?

[thezip]

At the risk of adding more bulk to your code, try this check first, as well as one for $_-> { TEST34) }.

if ($_->{ TEST33 } ) {
  <your previous code here ...>
}

[olus]

Where does $_ come from? Are those keys defined in the hash it references?

[Anonymous Monk]

Yes it is!


$data = ();
   $sql = sprintf $sql_fmt, $account->[$i]{ 'ACCOUNT#' };
   $data = exec_select( $sql );


foreach (@$data) {
....

[olus]

From this snippet and the first one I can understand that data is an array that references hashes. This last snippet shows that data may be defined with the result of the call to exec_select. Still, that shows no guarantee that the hashes in data have the keys $_->{TEST34} and $_->{TEST33}. You may be assuming that they are present, but they are not.