For each of the four banks, you are creating one
Entry widget
for each line in the bank's associated file. So if one of the bank files (like
banorte.txt) has two lines in it, there will be two
Entry widgets for Banorte. Is that what you are seeing?
Additionally, here are some other suggestions:
- You have four blocks of essentially identical code. You should factor the common code out into a subroutine:
sub make_entry {
my ($upperframe, $label, $filename) = @_;
...
}
make_entry($upperframe, 'Santander', "santa1.txt");
make_entry($upperframe, 'Banamex', "banamex.txt");
make_entry($upperframe, 'HSBC', "hsbc.txt");
make_entry($upperframe, 'Banorte', "banorte.txt");
This will make your code a lot easier to debug and maintain.
- You can change the foreground color of an Entry widget after you create it, and this will further simplify your code:
my $entry = $upperframe->Entry(-textvariable => ...)->pack(...);
$entry->configure(foreground => ...bank is active... ? 'red' : 'blue
+');
This also shows how to dynamically change the foreground.
- When creating the Entry I'd probably just use -text => ... instead of -textvariable => \$somevar. You are creating a reference to a lexical that you won't be able to refer to later once the subroutine returns. You can always get the contents of the Entry widget with $entry->get.