Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid

RFC: CGI::Uploader V 2.90_01

by Anonymous Monk
on Dec 01, 2008 at 04:32 UTC ( #727005=perlmeditation: print w/replies, xml ) Need Help??

Hi Folks I've re-written from scratch CGI::Uploader V 2.15, with the knowledge of that version's author Mark Stosberg, and uploaded the dev version to CPAN. I'd appreciate a few people taking it for a spin. TIA.

Replies are listed 'Best First'.
Re: RFC: CGI::Uploader V 2.90_01
by ysth (Canon) on Dec 01, 2008 at 06:15 UTC
      Hi ysth The original module was idiosyncratically written and badly documented, and contained various hard-coded decisions. Vast changes were made, based on what I wanted the module to do, compared to what it used to do. The list of changes is not so important, actually. What's important now is to study the new docs and decide if the module does in fact provide a user-friendly upload mechanism.
        "Vast changes were made, based on what I wanted the module to do, compared to what it used to do. The list of changes is not so important, actually."

        While I agree that it's useful for people to see if your interface is user friendly, to say that the list of changes isn't important seems to fly in the face of everyone using the original module doesn't it? If they're happy with the old module, why should they change without seeing the list of changes you've made?

        To disagree, one doesn't have to be disagreeable - Barry Goldwater

Re: RFC: CGI::Uploader V 2.90_01
by markjugg (Curate) on Dec 02, 2008 at 02:32 UTC

    Thanks your interest in this. I'm curious about the decision to move the imaging code into the core. Uploading could be about a lot of other transformations besides image resizing, and the old design of handing image transformations through a helper module seemed like a reasonable interface:


    gen_files => { 'my_thumb' => gen_thumb({ w => 100, h => 100 }), }
    transform => { imager => Imager -> new(), options => {xpixels => 400, ypixels => 500}, }
    That looks worse to me, and sets a precedent for supporting imagers internally, while before there was example of adding new transformers via plugins.
      Hi Mark. Actually, I'm very uneasy about embedding such restricted transformation logic in the module. The feedback has confirmed my suspicions that that part needs to be re-implemented. I was a good idea to call this one 2.90_01 and not 3.00 :-). Cheers

Log In?

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: perlmeditation [id://727005]
Front-paged by ysth
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others about the Monastery: (3)
As of 2021-12-01 18:56 GMT
Find Nodes?
    Voting Booth?
    R or B?

    Results (14 votes). Check out past polls.