Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl Monk, Perl Meditation
 
PerlMonks  

Re^2: Need to skip two lines

by drodinthe559 (Monk)
on May 06, 2009 at 20:11 UTC ( #762377=note: print w/replies, xml ) Need Help??


in reply to Re: Need to skip two lines
in thread Need to skip two lines

Here is the script I finally came up with. It seems to work; although, I would like your opinion on any improvements I should make.
while(<SOURCE>) { my $source = $_; #skip blank lines next if ($source =~ m/^(\s)*$/); if (substr($source,145,16) =~ /Page: 1/) { $page1 = 1; next; } if (substr($source,76,11) =~ /Run Listing/) { $reporttype = 1; next; } if (substr($source,72,9) =~ /Sorter: 2/) { $sorter2 = 1; if ($page1 == 1 and $reporttype == 1 and $sorter2 == 1){ ++$dcount; print substr($source,83,20) . "\n"; $page1 = 0; $reporttype = 0; $sorter2 = 0; next; } }

Replies are listed 'Best First'.
Re^3: Need to skip two lines
by linuxer (Curate) on May 08, 2009 at 18:48 UTC

    You could consider the following things:

    • Don't use $_ as loop variable; use $source directly
    • remove the parentheses in the regex (for skipping blank lines); you don't need to capture the whitespaces, do you?
    • compare fixed strings directly (without regex); check Equality Operators for info about eq and ne
    • I don't see a need for $sorter2; just leave it out.
    • If all your ifs are alternatives, you can use if/elsif/elsif(/else) and leave out the next calls.

    So this is, what I came up with:

    # don't bother $_; use $source directly as loop variable while ( my $source = <SOURCE> ) { # skip blank lines; no need for capturing () next if $source =~ m/^\s*$/; # compare fixed strings directly without regex; use operators eq o +r ne if ( substr( $source, 145, 16 ) eq 'Page: 1' ) { $page1 = 1; } elsif ( substr( $source, 76, 11 ) eq 'Run Listing' ) { $reporttype = 1; } elsif ( substr( $source, 72, 9 ) eq 'Sorter: 2' ) { # no need for $sorter2; just check the other variables and do +your stuff if ( $page1 == 1 and $reporttype == 1 ) { # just personal preference; post increment $dcount++; # personal preference; print a list instead of concatted s +trings print substr( $source, 83, 20 ), "\n"; $page1 = 0; $reporttype = 0; # leave out next, if there is no more code in the while-lo +op #next; } } # no other stuff here? }

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://762377]
help
Chatterbox?
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others contemplating the Monastery: (4)
As of 2018-07-23 05:50 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    It has been suggested to rename Perl 6 in order to boost its marketing potential. Which name would you prefer?















    Results (459 votes). Check out past polls.

    Notices?