Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change

Re (tilly) 1: Optimization for readability and speed (code)

by tilly (Archbishop)
on Apr 30, 2001 at 23:36 UTC ( #76718=note: print w/replies, xml ) Need Help??

in reply to Optimization for readability and speed (code)

I am with everyone else. Turning a string into an array of characters which you then join slices together from is a mistake. Plus your handling of globals is broken, rather than hand-code that, use local. That is what it is for. And Perl's readability and maintainability comes in making code short and sweet, not in overcommenting.

If you really want to avoid REs and make C programmers comfortable, then I would point you at unpack and substr. Then you at least get some higher order constructs to compensate you for not writing in C.

Oh, a question. I don't know what atomize is supposed to do, but the first molecule in your molecules list is unlikely to be exactly what you planned on...

But still I would structure this by somewhere documenting the format, put in an RE, and somewhere (possibly before the RE, possibly in general documentation) put a pointer at japhy's module for taking an RE apart and explaining it in plain English.

  • Comment on Re (tilly) 1: Optimization for readability and speed (code)

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://76718]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others chanting in the Monastery: (4)
As of 2018-06-23 07:25 GMT
Find Nodes?
    Voting Booth?
    Should cpanminus be part of the standard Perl release?

    Results (125 votes). Check out past polls.