Re^2: Lady Aleena's first working module

[Herkum]

Now you are doing one of my pet peeves, using to much syntax which is not clarifying the code at all. This is better,

my $type = shift;

return $type eq 'parts'             ? $parts[             rand @parts]
     : $type eq 'good_vs_evil'      ? $good_vs_evil[      rand @good_v
+s_eval]
     : $type eq 'lawful_vs_chaotic' ? $lawful_vs_chaotic[ rand @lawful
+_vs_chaotic]
     ?                                q{}

[Tux]

That kind of code will only work of there is just one return, and "" (or the hideous q{} from PBP) is the only possible alternative.
My example just simplifies the pre-emptive returns, and lives in the assumption that the default (after all the returns were done) still needs some real coding.

Personally, I like brevity, and both my code and yours are terse. I do not however think that your code is any clearer than mine. Both are clearer than the code of the OP though.