Beefy Boxes and Bandwidth Generously Provided by pair Networks
"be consistent"
 
PerlMonks  

Re^3: How can I avoid code repetition here

by JadeNB (Chaplain)
on Oct 17, 2009 at 21:35 UTC ( [id://801806]=note: print w/replies, xml ) Need Help??


in reply to Re^2: How can I avoid code repetition here
in thread How can I avoid code repetition here

my $str = $change_in_place && $default_argument ? $_ : $_[0]; $str =~ s/^($lchompstr)*//;
I think this would (in the case $change_in_place && $default_argument) change only a copy of $_, not $_ itself. Maybe one could somehow use a foreach loop iterating over a one-element list, but I don't see how this would work in the general case.
I think that you could just take advantage of the fact that “ternary conditionals preserve lvalue-ness”, and write:
($change_in_place && $default_argument ? $_ : $_[0]) =~ s/^(?:$lchomps +tr)*//;
(I've taken the liberty of making your parentheses non-capturing. :-) ) I'm not sure why you end with the $_[0] statement, though—it seems that you're returning the first argument even if you ignored it (because of $change_in_place and $default_argument).

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://801806]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others meditating upon the Monastery: (4)
As of 2024-04-25 17:48 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found