Code Review...

[spartan]

I was reading a new Meditation, and noticed one of the replies ((dws)Re: Delving Deeper into the World of Programming), and thought what a great idea. I am pretty new to perl, and I want to use it for my scripts instead of ksh. What dws said really hit home. Although there are several sys-admins on my team, none of us are really good enough (IMHO) to critique each other's code. Barring the creation of a new section to this site (Code Review) where can I submit my code to be reviewed by the people here? Is it advisable? Should there be a new section of the site devoted to this so that Seekers Of Perl Wisdom, or Meditations doesn't get potentially flooded with newbies requesting they have their code reviewed? This is a question best left to the folks that run PerlMonks, and the community that participates in it. Thank you for you time.

Very funny Scotty... Now PLEASE beam down my PANTS!

[footpad]

First off, as this appears to be your first post...welcome. Be sure to take some time to review the FAQ's and Monastery Survival Guide.

Adding a section for code review is an idea that has been kicked around before. The basic idea seems to be that while code posted anywhere will likely get some feedback, such a section would be designed from the get go for feedback and commentary. A place where it would be understood that you're checking your ego at the door and focusing strictly on the code itself.

Personally, I like the idea. However, I wouldn't mind seeing that ethic infuse itself a little more deeply in other parts of the Monastery itself. As mentioned in an earlier node, the simple act of posting code tends to imply that you want feedback from those who might understand things a little more clearly.

In any event, welcome and enjoy your stay. By the way, Search and Super Search are great ways to find previous discussions, suggestions, and so on. You can save a lot of time with those.

--f

[spartan]

Thank you footpad, I have begun to read the Monastery Survival Guide and decided to reply to this message. It's a big read, but for the month or so that i've been here observing, and reading I have not come across this unfortunately. Just one third of the way through I've found MANY helpful hints and suggestions. I must admit I was quite nervous about my first post here. So let me say thank you. I hope my next post is much better than my first.
-spartan

Very funny Scotty... Now PLEASE beam down my PANTS!

[arhuman]

Why don't you use craft or cool uses for Perl section to post your code and ask for comments, as other people do ?

Another option is to post your code on your homenode and ask in the CB for comments...
(for uncomplete/under developpement code)

UPDATE :
Shame on me for being so rude !
First of all WELCOME ! you deserve a less cold answer for your first post :-)
Hope to see soon some of your code on your homenode (or craft ;-)

"Only Bad Coders Code Badly In Perl" (OBC2BIP)

[aijin]

Even though your team mates may not be saintly in the ways of Perl, it doesn't mean that they can't be helpful in reviewing code. Everyone sees things differently, and another set of eyes just might see a flaw or a better way of performing a task that you could have missed.

We coders often end up in "code-love"...being too involved with our own code to see the problems contained therein. Sometimes we just need that helpful hand to smack us across the back of the head and snap us out of our reverie.