SendMail won't send mail

[belize]

I have a simple CGI that takes a form and sends an email with the contents of the form.

Everything appears to work fine and the success page shows (which should only show if the CGI correctly makes it through all the other sub routines).

Problem is that no email is being sent. I know I should be using CGI.pm, but the current CGI has always worked in the past, and is already in place with the forms and all.

Is there a way to test if SendMail is working? I have:

1. Looked for and not found any dead.letter file
2. Looked in the error logs (nothing)
3. Used the following code:

sub SendMail {
if (-e $FORM{'template'}) { }
else { &Error('Template File Not Found - Error at sendmail subscript')
+; }
open (FILE, $FORM{'template'});
@File = <FILE>; close (FILE);
open (MAIL, "|$mailprog -t") || &Error('Unable to Open Sendmail');
.
.
.
}

but no error shows up which makes me think that SendMail is opening.

I've checked the SMTP service on the host servers and they are running.

I'm running out of things to check. Any ideas?

[merlyn]

Not commenting on your sendmail problem, but I saw this glaring issue and had to perk up:

if (-e $FORM{'template'}) { } 
else { &Error('Template File Not Found - Error at sendmail subscript')
+; } 
open (FILE, $FORM{'template'});

What's to stop someone from sending C</etc/passwd> as your template? Or even worse, playing games with NULs, which terminate C's scan on the -e test, but not Perl's scan on the open!

Get that scary code out of your CGI at once.

-- Randal L. Schwartz, Perl hacker

[tilly]

Why would any error show up when you are doing an open without following the advice in perlsyn and putting in a check for errors? A check that should include what you are going and the context fo $!.

That said, I would suggest Mail::Send for the problem...

[rucker]

You don't show the close(MAIL), but I'm guessing that you're not checking errors there. If your "$mailprog -t" returns an error, it'll show up on the close.