Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister

Re: Control Flow - Multiple returns or nested conditionals

by superfrink (Curate)
on Oct 07, 2010 at 16:07 UTC ( #864028=note: print w/replies, xml ) Need Help??

in reply to Control Flow - Multiple returns or nested conditionals

In general I lean towards less nesting. Less nesting makes the code easier to map into a model in my head. A lot of nesting in one place make me question if there should be a subroutine.

I have seen code with CLAIM comments that signal to the reader that something is true at that point in the program. (Well, that the programmer intended it to be and believes it to be true.) See the following example.
sub foo { my($self) = @_; my $authentication = $self->authenticate_user(); if(! defined($authentication)){ return {status=>0, error=>"Authentication Failed", external_id=> +undef}; } # CLAIM : the user is authenticated my $profile = $self->get_user_profile(); if(! $profile->is_active()){ return {status=>0, error=>"User is not active", external_id=>und +ef}; } # CLAIM : the user profile is active my($external_id) = $self->find_external_id($profile); if(! defined($external_id)){ $external_id = $self->send_profile_to_partner($profile); } # CLAIM : the user profile has been sent to the partner return {status=>1, error=>undef, external_id=>$external_id}; }

Log In?

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://864028]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others drinking their drinks and smoking their pipes about the Monastery: (4)
As of 2021-07-26 13:26 GMT
Find Nodes?
    Voting Booth?

    No recent polls found