Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister

Re^3: Resizing MRTG (RRDTool) logs en-masse

by jwkrahn (Monsignor)
on Nov 30, 2010 at 02:23 UTC ( #874417=note: print w/replies, xml ) Need Help??

in reply to Re^2: Resizing MRTG (RRDTool) logs en-masse
in thread Resizing MRTG (RRDTool) logs en-masse

Also,  /.*rrd$/ will match both of the strings  "rrd" and  "rrd\n" so perhaps you should use  /.*rrd\z/ instead.

Or perhaps even:  'rrd' eq substr( $_, -3 )

Replies are listed 'Best First'.
Re^4: Resizing MRTG (RRDTool) logs en-masse
by McDarren (Abbot) on Nov 30, 2010 at 04:03 UTC
    It would be pretty unusual to have a file name that ends with \n, so I see that as an edge case that's probably not worth worrying about.

    It's probably better to have a check after the call to RRDs::info, so I've inserted:

    my $info = RRDs::info "$logsdir/$rrd"; # Check to ensure we actually have a valid rrd file unless ($info->{filename}) { print qq|"$logsdir/$rrd" doesn't appear to be a valid rrd log, + skipping\n|; next; }
    Which does the trick...
    $ touch foo.rrd $ ./ Starting, found 1 rrd files Processing foo.rrd "./foo.rrd" doesn't appear to be a valid rrd log, skipping Finished, processed 1 files in 0.00 seconds

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://874417]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others perusing the Monastery: (8)
As of 2018-06-22 14:22 GMT
Find Nodes?
    Voting Booth?
    Should cpanminus be part of the standard Perl release?

    Results (124 votes). Check out past polls.