file locking problem!

[kiseok7]

this is my file locking function..

but;

it seem to be failure often.

what is problem with my function...!?

and how about you, all?

show me the best file locking example..

thanks

#!perl

my $file = "hanul.txt";

lock($file);
open FILE, ">$file";
print FILE "you're locking...\n";
close FILE;
unlock($file);

# LoCk
sub lock{
    my $lFile = shift;
    my $LockFile = "$lFile.lock";
    my $EndTime = time + 45;
    while (-e $LockFile && time < $EndTime) { }
    if (!open (LOCK,">$LockFile")){
        return 0;
    }
    else{
        chmod 0666, $LockFile;
        $locked = 'Y';
    }
}

# uNLocK
sub unlock 
{
    my $lFile = shift;
    my $LockFile;
    if ($locked eq 'Y'){
        $LockFile = "$lFile.lock";
        close (LOCK);
        if (-e $LockFile) { 
            unlink ($LockFile);
        }
        $locked = 'N';
    }
}

[LD2]

In the future, a good place to start searching for anything here is using Super Search. To give you an understanding and a good introduction on File Locking, check out turnstep's tutorial File Locking.

[RatArsed]

Take a look at flock maybe?

--
RatArsed

[kiseok7]

thanks:) I know flock but my OS is windows :(

[RatArsed]

Still works; at least under ActiveState's distribution (for me, at least)

--
RatArsed

[Anonymous Monk]

This is a race condition. There is no reason to believe that because a file did not exist when the previous instruction was executed that it still does not exist (your operating system could have run another proccess in between). So when your while (-e $LockFile && time < $EndTime) loop ends there is no guarantee that the file does not exist (infact, even if there were no race condition, you have a time limit on this loop but never check to see if the loop terminated because time was up or if it terminated because the file doesn't exist -- but like I said, checking to see if the file doesn't exist would still be a bug). If you are unable to use flock(), you could see if you're able to use sysopen with the O_EXCL flag which will guarantee that the file does not exist when opened (if it does exist, the sysopen call will fail and you'll probably want to handle this rather than simply returning from the function)

[Chady]

flock()

---

He who asks will be a fool for five minutes, but he who doesn't ask will remain a fool for life.

Chady | http://chady.net/