Re: Nicer If...

[runrig]

One idea:

my @req_fields = qw(
 Shipping_address
 ...
 shipdayph
);
my @filled = grep { $query->param($_) } @req_fields;
failure if @req_fields && @filled

Update: I like suaveant's idea, though I think the conditional would be 'if $has == @ship_fields or $missing == @ship_fields'

Another update: Took suaveant's suggestion(s), thought I caught that first one :)

Ok, I get it now, duh..

[suaveant]

similar to mine, but probably a little better, if you did !$query->param($_) it would return a list of empty ones, tho, which would allow you to throw a useful error to the user, the check even still works, but I'd just check to see if $#filled == $#req_fields || !@filled, instead of hardcoding a number

                - Ant

[suaveant]

actually, since he wants them all, if one of them is not equal to zero, then you fail... the check is right, just tricky

                - Ant