make test and File::Spec problems

[Dirk80]

Hello,

I get warnings when I'm using "make test" with a ".t" file which contains e.g. the following line:

File::Spec->catpath("","/usr/bin");

Warnings

Use of uninitialized value $file in string ne at /usr/lib/perl/5.14/Fi
+le/Spec/Unix.pm line 136.
Use of uninitialized value $file in concatenation (.) or string at /us
+r/lib/perl/5.14/File/Spec/Unix.pm line 144.

If I'm executing the ".t" file directly with perl "t/abc.t" or with prove instead of make test then I don't get these warnings.

What can I do? I don't want to have these warnings, when the test cases are executed with "make test".

Thank you

Dirk

[dulwar]

The documentation for File::Spec::catpath specifies:

Takes volume, directory and file portions and returns an entire path. Under Unix, $volume is ignored, and directory and file are concatenated. A ’/’ is inserted if need be. On other OSes, $volume is significant.

    $full_path = File::Spec->catpath( $volume, $directory, $file );

The call in your script is missing the third parameter $file, so the catpath method is using an undefined value in the concatenation. If you change the line to

    File::Spec->catpath("","/usr/bin", "");

then you will not get the warnings.

[Dirk80]

Thank you. I'm sure that's the reason for the warnings. And I'd like to try it. But I first have to find out how to downgrade the module Test::Harness from 3.25 back to 3.23.

UPDATE

Downgraded to Test::Harness 3.23 with the following command within the cpan shell:

install ANDYA/Test-Harness-3.23.tar.gz

Then I checked that the correct version is installed with:

perl -MTest::Harness -e 'print "$Test::Harness::VERSION\n"'

Then I updated the line in the test script. And you are right. The warnings are gone now also when I'm using Test::Harness Version 3.23.

[chromatic]

Update your version of Test::Harness. The newest releases (I believe 3.24 and later) do not unilaterally enable warnings.

[Dirk80]

Thank you. I had version 3.23 of Test::Harness and now updated to 3.25. Now it is working without warnings.

Is the warning now just suppressed from the new Test::Harness module or should I change something in the code to really solve the warning?

[chromatic]

When earlier versions of T::H launched external Perl processes in which to run your tests, they unilaterally added the -w flag. That enables warnings globally throughout the entire Perl process, even if the author didn't develop with warnings enabled.

Since the release of Perl 5.6.0 in early 2000, the warnings pragma has had lexical scoping, so that individual modules, files, and scopes can enable or disable warnings on their own.

Something somewhere in File::Spec produces that warning, but no one who's patched that module has felt the need to fix it because it's clearly not an error and it only produces a warning if you ignore lexical warnings.