Re^2: DBD::ORacle: Not able to insert into Database

[slayedbylucifer]

Roboticus, Finally I got it working. there were quite a few issues apart from the cleanliness:

- First, The chomp part that you said not working here although it was essential. Please find my discussion on below threads: http://stackoverflow.com/questions/11645696/perls-chomp-chomp-is-removing-the-whole-word-instead-of-the-newline Chomp is removing the whole word instead of the newline

- I had this chomping problem way before I created this thread. I have documented solution on the stackoverflow one. will post my solution on perlmonks as well

- Second, for whatever reason, I had to unassign "primary Key" column by logging to the SQL developer. Although my entries were not duplicates...still..I had to do it

- Third, I was uploading the values in a wrong way. The DBI documentation led to use the "$dbh->quote" method to upload strings.

- Finally, I used Text::CSV to retrieve individual values of my CSV and then uploaded them using the "$dbh->quote".

Here is the csv:

vm,farm,dmz
name1,farm1,z1
name2,farm2,z2
name3,farm3,z3

and here is my code:

#!/usr/bin/perl -w

use strict;
use Text::CSV;
use DBI;

my $csv = Text::CSV->new ( { binary => 1 } )  
                  or die "Cannot use CSV: ".Text::CSV->error_diag ();

open my $fh, "<:encoding(utf8)", "test.csv" or die " $!";

<$fh>; ### this is to remove the column headers.

my $dbh = DBI->connect ("dbi:Oracle:host=<hostname>;sid=<SID>;port=152
+6", 'username', 'password',
                        { RaiseError => 1, AutoCommit => 1, TraceLevel
+ => 0 })
                        or die "Cannot create Database Handle: $DBI::e
+rrstr()";


while ( my $row = $csv->getline ($fh))
{
        my $col1 = $dbh->quote ("$row->[0]");
        my $col2 = $dbh->quote ("$row->[1]");
        my $col3 = $dbh->quote ("$row->[2]");
        $dbh->do ("INSERT INTO CLUSTER_MAPPING (VM, FARM, DMZ) VALUES 
+($col1, $col2, $col3)");
}

$dbh->disconnect();
close $fh;

Thank you very much for your advice and time.

[mje]

1. The "chomp issue" was that you expected chomp to return the chomped string but it instead returns the number of characters chomped.
2. I don't believe you needed to remove the primary key. I think you had some other issue but that you changed more than one thing at once. If the column values are unique or you are going to select via that column you want an index or unique index. As you started with problems attempting to read from a file with <> I suspect you somehow where reading from stdin and hence it looked like your script was hung. That is why I suggested pressing ctrl/d.
3. It was suggested you inserted the values as parameters and that is still the best way to do it. As you have it you are having to build a SQL string each time when in fact before your while loop you could simply do one prepare with placeholders and then only call execute inside the while loop. It would also avoid all those quote calls.

[slayedbylucifer]

mje, I will be working on your suggestion and will modify the script accordingly. Will let you know how it goes. Thanks for your time.

[slayedbylucifer]

mje, here is my code after following your suggestions.

sub upload
{
        my ($csv_file, $table, $col1, $col2, $col3) = ($_[0], $_[1], $
+_[2], $_[3], $_[4]);

        my $csv = Text::CSV->new ( { binary => 1 } ) or die "Cannot us
+e CSV: ".Text::CSV->error_diag ();
        open my $fh, "<:encoding(utf8)", $csv_file or die " $!";
        <$fh>; ### this is to remove the column headers.

        my $dbh = DBI->connect ("dbi:Oracle:host=<hostname>t;sid=SID;p
+ort=1526", 'username', 'password',
                                { RaiseError => 1, AutoCommit => 1, Tr
+aceLevel => 0 })
                                or die "Cannot create Database Handle:
+ $DBI::errstr()";

        my $sth = $dbh->prepare ("INSERT INTO $table ($col1, $col2, $c
+ol3) VALUES (?,?,?)");

        while ( my $row = $csv->getline ($fh))
        {
                $sth->execute ($row->[0], $row->[1], $row->[2]);
        }

        $sth->finish();
        $dbh->disconnect();
        close $fh;
}

Thank you very much for guiding me.