Re^2: Bind zone file search

[ranceh]

What version of perl did you use?

This code does not generate any errors, but does not generate output.

[Kenosis]

Hi, ranceh

Am using v5.16, but there's nothing in the code that would prevent its execution by much earlier versions, so I suspect the issue is something else. Try the following change to the subroutine:

use strict;
use warnings;

my $directory = './zones';
my %zones     = getZoneHash($directory);

print "$_ -> $zones{$_}\n" for keys %zones;

sub getZoneHash {
    my ($dir) = @_;
    my %hash;

    my @files = grep -f, <"$dir/*">
      or die "Problem getting filenames in $dir/: $!";

    local $/;

    for my $file (@files) {
        open my $fh, '<', $file or die $!;
        my $data = <$fh>;
        close $fh;

        $hash{$1} = $2
          if $data =~ /zone\s+"([^"]+)".+masters\s+{\s*([^}\s]+)\s*}/s
+;
    }

    return %hash;
}

Now there's a check for file names being read from the desired directory. The script will die with a message if none were read.

If you're still getting the same results, temporarily place the following just below the close $fh; line:

print $data;
exit;

You should see a zone stanza that the regex would process. If not, the next step would be to figure out why the file contents are not being read into $data.

[ranceh]

I think I found the problem.

I modified your regex slightly in the beginning it starts with "/^zone..."

I found after posing this question last night that a few of the zone files have stanzas commented out.

The ^ in combination with the change to $/ seem to conflict with each other.

I think it would be easier to add a not part to the regex before zone so that what is before zone is not a comment character identifier.

[Kenosis]

Ah, good! Do you have an example of the commented-out stanzas? I suspect the regex can be modified to manage these exceptions.