moving files

[Anonymous Monk]

system ("mv $fil_nm ./reports"); $filnm is present inside foreach loop at the end i'm using system command finally i want to mmove all the $fil_nm to a directory reports.but instead only the last executed $fil_nm is moving to a directory reports can u help me how to move all the contents in the $fil_nm to reports directory

[Athanasius]

It’s hard to say what’s going wrong when you don’t show either the loop code or the contents of $fil_nm.

However, it’s not necessary to use system — the core module File::Copy has a move function. Here’s a guess at what you’re trying to do:

use File::Copy;
my @files_to_move = split(/\s+/, $fil_nm);  # assuming $fil_nm contain
+s a space-separated list of files to move
move($_, './reports') for @files_to_move;

Hope that helps,

[tobyink]

Is your system command inside the loop? (That is, before the closing }.) It should be.

Also you seem to inconsistently refer to $fil_nm and $filnm; these are different variable names, so if you mix them up randomly in your code, that will cause odd results.

[Anonymous Monk]

by mistake i've typed $fil_nm in two ways my variable is $fil_nm only

[Anonymous Monk]

no my system command is outside the loop and i want to move the $fil_nm files to reports directory only after completing the foreach loop outside that system command is present . i'm facing this problem help me over this

[2teez]

You could use File::Copy with File::Find instead of

system ("mv $fil_nm ./reports")

like so:

use warnings;
use strict;

use File::Copy qw(move);
use File::Spec;
use Cwd qw(abs_path);
use File::Find;

my $path      = $ARGV[0];
my $final_dir = File::Spec->rel2abs("./report");
$path = abs_path($path);
find(
    sub {
        chomp;
        return if $_ eq '.' or $_ eq '..';
        move( $_, $final_dir );
    },
    $path
);