2teez,
I noticed a few things that could help the performance of your File::Find solution above.
In the search sub:
find( \&search_all_folder, $path );
sub search_all_folder {
chomp $_;
return if $_ eq '.' or $_ eq '..';
read_files($_) if (-f);
}
- The chomp isn't needed here since File::Find changes to the subdirectory and returns just the filename in $_.
-
The return if line isn't needed since in the next line the read_files() sub is only called for regular files.
'.' and '..' are directories so they won't be included.
-
Since the OP specified only to print text files why not use the file test -T? The -f test will allow the program to attempt to print binary files which is pretty annoying if there are any lurking in a subdirectory.
In this function:
sub read_files {
my ($filename) = @_;
open my $fh, '<', $filename or die "can't open file: $!";
while (<$fh>) {
print $_, $/;
}
}
-
Printing $/ when printing each line will cause an extra blank line to appear since you did not use chomp when the line was read.
And one question: what is the reason for using abs_path? I find that File::Find works fine with relative
pathnames. Does it help the performance if an absolute pathname is given?
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|