|Pathologically Eclectic Rubbish Lister|
Wow. You disagree with me, so you downvote me. Thank you for ensuring that I won't get into any future discussions with you.
However, that isn't quite correct. I specifically said that since we started using Perl::Critic with some of the inexperienced guys I work with, their code quality has improved, and the number of mistakes they have made has decreased. That specific experience is why I believe it helps improves beginners code: I have personally seen it happen.
You simply state: "I like; I use it; therefore it must be good."
No, I didn't. I'll thank you for not putting words in my mouth. In fact, I'll help you by directly stating what I mean, in my own words: "I like it. I have personally benefited from it, both through direct use, and from its use by coworkers. For my purposes, it is a good and useful tool."
Pick (almost) any single one of P::C critiques and open up the discussion here to all comers comments; and I'll bet you'll never reach a consensus; without you give a specific example of the critiqued construct or idiom in situ. And even if you get a consensus for that specific usage, it will be only for that specific usage; and probably a contrived one at that.
You are correct in that you will probably never get 100% agreement on, well, pretty much anything related to Perl. Especially when it comes to things like best practices. Hell, getting 100% agreement is almost a violation of Perl's TIMTOWTDI culture. But, that doesn't mean that I don't have personal opinions on best practices. And it doesn't mean that a significant number of people in the community don't have opinions on best practices. And it doesn't mean that my coworkers don't have opinions on best practices.
Can Perl::Critical assist us, at least to some degree, with catching violations of those best practices? Yes. Is Perl::Critic perfect? Absolutely not. Is it useful? To me, absolutely. Do I think it's better to have new users run it, research what it spits out, and learn from it, rather than blindly continue making potential mistakes? Yes.
I think this comes down to a fundamental difference in viewpoint on learning. You seem to imply that Perl::Critic is always bad, and that the only valid way to learn best practices is through code reviews with a presumably experienced Perl coder. I believe that a code review with an experienced Perler is absolutely better than Perl::Critic, but I also believe Perl::Critic is better than nothing (and many people don't have a Perl guru at their beck and call). Finally, I also believe that Perl::Critic use, especially when supervised by an experienced Perl coder, can be a very beneficial tool for learning.
I find it to be (one of many) useful tools. You obviously hate it. Nothing in this discussion is going to change either of our opinions, and I'm not interested in arguing with someone who downvotes first, and argues later. I'm out.
In reply to Re^4: The Most Essential Perl Development Tools Today