Beefy Boxes and Bandwidth Generously Provided by pair Networks
Welcome to the Monastery
 
PerlMonks  

comment on

( #3333=superdoc: print w/replies, xml ) Need Help??
And here you have the code, finally crafted after 37 steps of development.

Looks more like 37 hours sleepless, uninterrupted hacking.

Is this a joke? If so, I didn't get it.

I think this is unmaintainable, "write-only code". Here's why:

  • Chaotic indent. 2 spaces, 4, 6, 10, 14, 18, with no obvious rules when and how indenting happens.
  • Random amount of whitespace around operators
  • Extra long lines (33% have more than 80 chars) full of commands - Perl ain't MUMPS, stuffing as much code as possible into a single line does not make the code faster.
  • perl 4 function calls with & prefix - my favorite. The last Perl 4 release was about 20 years ago (4.036 released 1993-Feb-05).
  • Comments all over the place, but rarely useful. Hardly readable even with syntax highlighting. What is the relation of "use warnings" and "CPANnn" or "a big ABuse of Data::Dump::Streamer"?
  • String evals. Evaluating unverified data read from the network. Twice.

This really looks like code copied from about 3 or 4 different examples, hastily glued together after too much coffee and severe sleep deprivation.

perltidy with default options expands this mess from 100 to 160 lines, slightly more readable, but still ugly.

perlcritic --brutal emits 130 warnings, 1.3 warnings per line, recommends refactoring. perlcritic --harsh still emits 28 warnings, still recommends refactoring. Even perlcritic --gentle does not remain silent.

Alexander

--
Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)

In reply to Re: CPAN Namespace Navigator by afoken
in thread CPAN Namespace Navigator by Discipulus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others taking refuge in the Monastery: (10)
As of 2021-06-12 20:17 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    What does the "s" stand for in "perls"? (Whence perls)












    Results (53 votes). Check out past polls.

    Notices?