comment on

What's going on behind the scenes is actually pretty interesting. So when you say PPI::Document->new(\$sub_h{$name}{content})->find_first('PPI::Statement::Sub'), you're creating a new document, however, you're not keeping a reference to that document, so it is immediately DESTROYed - which clobbers every element of that document - including the sub returned from find_first!

So to fix that, split that statement into two, saving the document in a variable so that it is not immediately destroyed. But the code still doesn't work, because that document is still getting destroyed at the end of the loop body, removing the elements before you get to save. So to fix that, you need to disassociate the sub element from its document via remove.

There's one more minor issue, which is that you need to remove the stub, since you're replacing it with the stored one. So putting all that together gets you this, which works (file after should be identical to before):

#!/usr/bin/env perl
use warnings;
use strict;
use 5.010;
use PPI;

my $raw = <<'__RAW__';
package FeeFi;
sub Fee {
    print "Fee\n";
}
sub Fi {
    print "Fi\n";
}
1;
__RAW__

my %sub_h;
{
    my $document = PPI::Document->new(\$raw)
        or die "oops!";
    $document->save('before');
    for my $sub (@{$document->find('PPI::Statement::Sub') || []}) {
        next if $sub->forward;
        $sub_h{$sub->name}{content} = $sub->content;
        my @elements = $sub->block->children;
        for (my $i=0; $i < @elements; $i++) {
            $elements[$i]->remove;
        }
    }
    $sub_h{''}{content} = $document->content;
}
{
    my $document = PPI::Document->new(\$sub_h{''}{content})
        or die "oops creating ''!";
    for my $stub (@{$document->find('PPI::Statement::Sub') || []}) {
        next if $stub->forward;
        # 1. store the document in its own variable
        my $doc = PPI::Document->new(\$sub_h{$stub->name}{content});
        my $sub = $doc->find_first('PPI::Statement::Sub');
        # 2. remove the sub element from its document
        $stub->insert_after($sub->remove)
            or warn "Can't insert_after!";
        # 3. remove the stub
        $stub->remove;
    }
    $document->save('after');
}
[download]

In reply to Re: PPI replacing/updating a stub by haukex
in thread PPI replacing/updating a stub by clueless newbie

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


We don't bite newbies here... much
	PerlMonks