Everything is a matter of taste, and reading perl is a function of how you are used to seeing perl written, but I would go for more explicit var names and just a couple comments. The code itself is failry easy to read.
foreach my $line (@data) {
my ($linecount, $filename) = split(/\s+/, $line);
$filename =~ s/^$in_prefix//; # strip base directory from filename
my ($campaign, $month, $fname) = split('/', $filename); # info is st
+ored in the directory nesting
push @files, { campaign => $campaign,
month => $month,
file => $fname,
count => $count,
sort => "$campaign:$month:$file" };
}
It is a bit more verbose, and may be a bit slower because it uses explicit temporaries (instead of $_). I personally hate $_ and avoid it like the plague. I know this isn't a widely shared view.
But hey, you asked for opinions, right?
-jackdied
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.