Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change

comment on

( #3333=superdoc: print w/replies, xml ) Need Help??

It occurs to me that at least one thing you might want to do is to determine whether the programmer is 'friend' or 'foe'. All of the advice given so far will still have to take this small fact to account. If this were an ideal world, things might be different, but just the existence of such code suggests that there is a significant problem lurking in your organization. You might also do well to find out what backing this person has, I assume that he or she must have some, how else to explain this sort of mess? Actually the more I think about it, the more I think that this isn't a coding problem, this is an office politics problem. I suppose to be generous, the code and the person involved might be remedied, but such an investment might well cost more than it's worth.

Tactically speaking, I would assume the role of 'The Fool with Questions'. Essentially, have the programmer explain all of the anomalies you've found, to you, because you—of course, just don't understand. This way, the onus is one the author to either save themselves or not.

And if things truely get ugly, be prepared and bring copies of your node and the responses to it to the meeting! Just a thought!


"Never try to teach a pig to sing…it wastes your time and it annoys the pig."

In reply to Re: How do you critique another person's code? by hsmyers
in thread How do you critique another person's code? by Rhose

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?

    What's my password?
    Create A New User
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others exploiting the Monastery: (6)
    As of 2019-09-24 09:30 GMT
    Find Nodes?
      Voting Booth?
      The room is dark, and your next move is ...

      Results (290 votes). Check out past polls.