Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl Monk, Perl Meditation

Comment on

( #3333=superdoc: print w/replies, xml ) Need Help??
I keep hearing "if it ain't broke don't fix it" at the back of my mind. ... My boss was the original author. I'll obviously have to tread lightly so as to not offend.

These are the two hurdles to work through first. I've seen people take over code that "worked good enough," and then get blamed for slacking or incompetence when it took them a long time to add new features. To avoid this happening to you, people need to know what the code looks like under the covers. Your boss being the author complicates things, but there may be a tactful way to approach the issue.

Were I in this position, I would first try to make things safe for my boss by leading off with something like "I can appreciate that you must have been working under non-ideal conditions when you wrote this, because I can see that you didn't have time to ...", and then see if you can't get him to agree that a bit of cleanup and refactoring is necessary before you try to add new functionality.

To give yourself confidence that you're not breaking things, you might want to develop some coarse-grained unit tests before you start.

In reply to Re: So I'm in a bit of a quandary by dws
in thread So I'm in a bit of a quandary by vek

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?

    What's my password?
    Create A New User
    and all is quiet...

    How do I use this? | Other CB clients
    Other Users?
    Others scrutinizing the Monastery: (5)
    As of 2018-06-23 22:39 GMT
    Find Nodes?
      Voting Booth?
      Should cpanminus be part of the standard Perl release?

      Results (126 votes). Check out past polls.