This is an example of why the best Perl books say we should stick with Lincoln Stein's CGI module rather than try to write this ourselves.

The above code, aside from reinventing the wheel, has a variety of problems. The most immediately obvious one is the following section of code:

foreach $form (@form_data){
    (my $one, my $two) = split(/=/, $form);
    if ($one =~ m/\+/){
        $one =~ s/(\+)/" "/eg;
    }
    if ($two =~ m/\+/){
        $two =~ s/(\+)/" "/eg;
    }
    $one =~ s/%([\da-fA-F][\dA-Fa-f])/pack("C", hex($1))/eg;
    $two =~ s/%([\da-fA-F][\dA-Fa-f])/pack("C", hex($1))/eg;
    $form{$one} = $two;
    $params{$one} = $two;
}
[download]

This code is duplicated! It should be a subroutine.

If you are going to reinvent the wheel, you should only do so when you are really comfortable with the language in question. Otherwise, these problems creep in and later down the road, when you're still using your reinventions, you'll come back to them and find they need to be rewritten to get around issues like this.

And why are the hashes %forms and %params duplicated? The way they're created above, they are identical. I could go on, but that's enough for now.

Cheers!

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.