comment on

I am continually working on a set of modules for a system I am planning to use in the (hopefully) near future. I have come across something new that I have never given much thought to. This is not a problem I have come across, but more of a question of style and perhaps preference. In these modules, I have several subroutines that give a hash as a return value. My question to you wise and wonderful monks is whether I should return a hash or a hash reference.

To explain perfectly well, this is an example of one of my subroutines:

package Module::Name;

# require CGI, strict, constructor, all other code...

# A sub to return a [hash|hash reference] of CGI params.
sub get_params {
  my $self = shift;
  my %input;
  $input{$_} = $self->{$cgi_handle}->param($_)
      foreach $self->{$cgi_handle}->param());

  # The two possible ways of returning the hash.
  # Is there a preference (style or personal)
  # as to which one I should use?
  return %input;  # return hash
     # OR
  return \%input; # return hash reference
}
[download]

The first method of returning the hash (return %input;), would be handled as such:

my $CGI = new Module::Name;
my %INPUT = $CGI->get_params();
print $INPUT{'node'};
[download]

The second method of returning the has (return \%input;), would be handled as such:

my $CGI = new Module::Name;
my $INPUT = $CGI->get_params();
print $INPUT->{'node'};
[download]

My guess is that this is probably a completely personal preference rather than style, but I might be wrong. If it is personal preference, I'd like to know which method other perl users prefer and perhaps any reason(s) as to why. :)

In reply to Subroutines: Returning a hash vs. hash reference by mt2k

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Problems? Is your data what you think it is?
	PerlMonks