I haven't tested this but believe it is cleaner to write as

sub commit () {
    ($T || ${ caller() . '::T' })->commit;
    goto END_XACTION;
}

sub rollback () {
    ($T || ${ caller() . '::T' })->rollback;
    goto END_XACTION;
}

sub transaction (&) {
    my ($block) = @_;
    local $T = ${ caller() . '::T' } or croak "\$T not set";

    local $@;
    eval {
        $T->begin_work;
        $block->();
    };
    $@ ? rollback : commit;

    END_XACTION: die $@ . "commit not safe after errors, transaction r
+olled back"
        if $@;
}
[download]

I would suggest you work with die instead though - that will work with nested transactions and require fewer hoop jumps. You can then also easily add some more error checking:

sub commit {
    require Carp;
    Carp::croak("Can't commit outside a transaction");
}

sub rollback {
    require Carp;
    Carp::croak("Can't rollback outside a transaction");
}


sub transaction (&) {
    my ($block) = @_;

    my $caller = caller();

    local *{"${caller}::commit"} = sub { die "!COMMIT\n" };
    local *{"${caller}::rollback"} = sub { die "!ROLLBACK\n" };

    local $@;
    eval {
        $T->begin_work;
        $block->();
    };

    if(!$@ or $@ eq "!COMMIT\n") {
        ${"${caller}::T"}->commit;
    }
    elsif($@ eq "!ROLLBACK\n") {
        ${"${caller}::T"}->rollback;
    }
    else {
        ${"${caller}::T"}->rollback;

        require Carp;
        Carp::croak($@ . "commit not safe after errors, transaction ro
+lled back");
    }
}
[download]

Makeshifts last the longest.

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.