First of all, the line:
my $line = $self->SUPER::getline() || return undef;
has a problem; what if $self->SUPER::getline()
returns "0"? Or ""? (which may happen if you don't subclass
from IO::Handle directly, or if you are working with IO layers).
As for what to return if the line is illformatted, you can do
several things:
- Return 'undef' after setting $! or some other global
variable, and leave it to the caller to inspect it.
- die with an appropriate message; it's up to the caller
to use eval {} and catch an error.
- Return an overloaded object that is undefined in boolean
context, but which can be inspected by the caller. You
might return an overloaded object if your superclass
returns undefined as well.
- Always return an object, whether on failure or success.
It's up to the caller to inspect that object, and
retrieve either the string, or the failure reason.
Anyway, you need to return something special, which you
document well, and it's up the caller to inspect your
return value and handle appropriately.
I probably would use the first suggestion.
Abigail
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|
