The code could be tidied up a little but it looks like it should work. It isn't checking anything that might already be in the table, however, just the set of data you are currently inserting, is that intentional?

Some tips:
You can replace:

while ($count<=@IDnumber) {
  if ($match == $IDnumber[$count]){
    goto NEXTLINE1;
  }
  $count++;
}
[download]

with:

next if(grep {$_ eq $match} @IDnumber);
[download]

and you don't really need the label/goto, the command 'next' does exactly that, ie jump back to the top of the loop and start the next iteration.

As to the IDs, first, you should probably check the current values in the table, to see if the one you want to insert is present, assuming there are any. But a much easier way to do this would be to make the field in the table unique ('no duplicates', in Access), in which case it will simply refuse to insert that line, and you can carry on to the next.

C.

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.