It works, but it’s surprising. I had to blink and stare for a moment before I noticed that it actually does do what you intended. All in all, considering the other things I mentioned, I’d write the loop like this:
while ( <INFILE> ) {
next if not /ver = '(.*?)'/;
$old_version = $1;
close INFILE;
last;
}
Better yet, if you just opened the file:
{
open my $fh, '<', $filename
or die "Can't open $filename: $!\n";
while ( <$fh> ) {
next if not /ver = '(.*?)'/;
$old_version = $1;
last;
}
}
In which case $fh goes out of scope at the end of the block and the file is closed automatically; much nicer. I only explicitly close files that I write to (because they you want to check the return value of close, which may fail for such reasons as “disk full” or the like).
In fact, if the file is so small that you don’t mind slurping it, you could just say
use List::Util qw( first );
my $old_version = do {
open my $fh, '<', $filename
or die "Can't open $filename: $!\n";
first { /ver = '(.*?)'/ } <$fh>;
};
Makeshifts last the longest.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.