It also helps to actually "return 1;" instead of just "1;" In general use the short form only when you are really at the end of a subroutine. do blocks are not really subroutines.

#!/usr/bin/perl

use strict;
use warnings;

# let's just remove the else

sub foo {
    if (@_) {
        return do { my $dummy; return 1; };
    }
    0;
}

sub bar {
    if (@_) {
        return do { my $dummy; return 1; };
    } else {
    0;
    }
}

print foo() . ' ' . foo('baz') . "\n";    # 1 0
print bar() . ' ' . bar('baz') . "\n";    # also 1 0
[download]

Update:
I noticed that the above script is bad style for a direct return from the subroutine. You should use eval instead of do. See the example below.

 #!/usr/bin/perl

 use strict;
 use warnings;

 # let's just remove the else

 sub foo {
     if (@_) {
         return 10 + do { my $dummy; return 1; };
     }
     0;
 }

 sub bar {
     if (@_) {
         return 10 + eval { my $dummy; return 1; };
     }
     0;
 }

 print foo() . ' ' . foo('baz') . "\n";    # 1 0
 print bar() . ' ' . bar('baz') . "\n";    # 11 0
[download]

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.