This is too much because thinking of how to say what it does out loud takes more than a couple of seconds. And yes, 'gbr' belongs elsewhere. And the uc() looks like maybe a display thing that should be in a template somewhere. Even the most naive and verbose rewrite I can think of scans easier for me:
our $DEFAULT_COUNTRY = 'gbr';
[...]
my $country = $card->country;
if ($country) {
if ($country eq $DEFAULT_COUNTRY) {
$country = '';
} else {
$country = '[' . uc($country) . ']';
}
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|