One thing I don't like is that $country is first used as temporary storage for
the result of the function call, then used to mean something almost completely
different. Variables are supposed to be variable, but this feels like a case
where separate variables would map the business rules better.
Oh, and what if $card->country is "0"? I'm guessing you would want that translated to "" or "[0]".
Update: I wasn't going to propose an alternative, but ended up doing so as a response to another respondent: Re^2: How Much Is Too Much (on one line of code)?.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|
