Beefy Boxes and Bandwidth Generously Provided by pair Networks
Syntactic Confectionery Delight

comment on

( #3333=superdoc: print w/replies, xml ) Need Help??

Seems to me your main block should look more like:

#!/usr/bin/perl -w use strict; my @main = &open_file_main (); my @annot = &open_file_annot (); open OUTPUT, '>', 'output.txt' or die "Cannot open $!"; # loop through the main data file foreach my $md (@main) { chomp $md; my ($main_chrom, $winl, $winr) = split (/\s{2,}/, $md); foreach my $ad (@annot) { my ($an_chrom, undef, undef, $prol, $pror, undef, undef, undef +, $mess) = split (/\s{2,}/, $ad); next unless $main_chrom eq $an_chrom; my (undef, undef, $name) = split (/\;/, $mess); next if $winr < $prol or $winl > $pror; print OUTPUT "$name\t $md\n"; #last; } } exit;

Note that there is no need for a sub to open the output file! If you need to do complicated stuff in the context of opening the output file, return the file handle from the sub - do not use a 'global' variable that is set as a side effect!

Perl is environmentally friendly - it saves trees

In reply to Re: Faulty Control Structures? by GrandFather
in thread Faulty Control Structures? by bioinformatics

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or or How to display code and escape characters are good places to start.
Log In?

What's my password?
Create A New User
Domain Nodelet?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others meditating upon the Monastery: (4)
As of 2022-05-19 22:58 GMT
Find Nodes?
    Voting Booth?
    Do you prefer to work remotely?

    Results (72 votes). Check out past polls.