comment on

In the code below I would like the Hash filled in the subroutine FillHashOne() to be accessible as a reference in $Hash. However all I get is an empty hash ref.

I think I am missing the section of my brain that is needed to understand references. I have read all the tutorials and have used references many times, but then I run into a situation like this that stymies me.

All help and suggestions are appreciated!

Update: Duh! I messed up my closure and had it inside the subroutine. It works when I fixed that.

#!/usr/bin/perl
use strict;
use warnings;

use constant false            => 0;
use constant true             => 1;

$| = true;

use Data::Dumper;

my $Hash = {};

sub FillHashOne
{
   my %HashOne;
{
   my ($Key, $Value) = @_;

   if(!defined($Key))
      {
      return(\%HashOne);
      }
   else
      {
      $HashOne{$Key} = $Value;
      }
}
}

$Data::Dumper::Indent      = 3;
$Data::Dumper::Purity      = true;
$Data::Dumper::Varname     = 'Hash';
$Data::Dumper::Quotekeys   = true;

$Hash->{'One'} = 1;
$Hash->{'Two'} = 2;
$Hash->{'Three'} = 3;
$Hash->{'String'} = 'Foo Bar';

print __LINE__ . ":Main:\$Hash:\n" . Dumper($Hash);
for (my $i = 0; $i < 10; $i++)
   {
   FillHashOne($i, "Value:\[$i\]");
   }
$Hash->{'HashOne'} = FillHashOne(undef());
print __LINE__ . ":Main:\$Hash:\n" . Dumper($Hash);
[download]

Updated Code:

#!/usr/bin/perl
use strict;
use warnings;

use constant false            => 0;
use constant true             => 1;

$| = true;

use Data::Dumper;

my $Hash = {};

{
   my %HashOne;
sub FillHashOne
{
   my ($Key, $Value) = @_;

   if(!defined($Key))
      {
      return(\%HashOne);
      }
   else
      {
      $HashOne{$Key} = $Value;
      }
}
}

$Data::Dumper::Indent      = 3;
$Data::Dumper::Purity      = true;
$Data::Dumper::Varname     = 'Hash';
$Data::Dumper::Quotekeys   = true;

$Hash->{'One'} = 1;
$Hash->{'Two'} = 2;
$Hash->{'Three'} = 3;
$Hash->{'String'} = 'Foo Bar';

print __LINE__ . ":Main:\$Hash:\n" . Dumper($Hash);
for (my $i = 0; $i < 10; $i++)
   {
   FillHashOne($i, "Value:\[$i\]");
   }
$Hash->{'HashOne'} = FillHashOne(undef());
print __LINE__ . ":Main:\$Hash:\n" . Dumper($Hash);
[download]

In reply to Not So Complex Hash Question by NateTut

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Think about Loose Coupling
	PerlMonks