I generally prefer less nesting, and thus direct return. However your example suffers from code duplication for the version that uses return(), though that's not necessary:
sub err {
{ status => 0, error => shift(@_), external_id => undef);
}
sub foo
{
my($self) = @_;
my $authentication = $self->authenticate_user();
return err('Authentication Failed') unless defined $authentication;
my $profile = $self->get_user_profile();
return err('User is not active') unless $profile->is_active;
my($external_id) = $self->find_external_id($profile);
if(! defined($external_id)){
$external_id = $self->send_profile_to_partner($profile);
}
return {status=>1, error=>undef, external_id=>$external_id};
}
Perl 6 - links to (nearly) everything that is Perl 6.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|