You save an alloc and free that wayYes - I think that's a better approach. (However, specifying a return type of char * and then returning an SV * is something that doesn't work well for me ;-) I find the following works as expected (without any need to dynamically allocate/free memory)
, and doesn't throw any warnings:
SV * get_proc_name( int processID )
{
char szProcessName[MAX_PATH] = {0};
HANDLE hProcess = OpenProcess
( PROCESS_QUERY_INFORMATION |
PROCESS_VM_READ,
FALSE, processID );
if (NULL != hProcess )
{
HMODULE hMod;
DWORD cbNeeded;
if ( EnumProcessModules( hProcess, &hMod, sizeof(hMod), &cbNee
+ded) )
{
GetModuleBaseName( hProcess, hMod, szProcessName, MAX_PATH
+ - 1);
}
else {
szProcessName[0] = '#';
szProcessName[1] = 0;
}
}
else {
szProcessName[0] = '*';
szProcessName[1] = 0;
}
CloseHandle( hProcess );
return newSVpv(szProcessName, 0);
}
Cheers, Rob
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|