Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling

Comment on

( #3333=superdoc: print w/replies, xml ) Need Help??

Hi gang!

I just wrote a Hangman script in Perl. It pretty much portrays the extent of my Perl knowledge. This script is just about as good as I am when it comes to Perl, if that makes sense. I'm wondering if you guys can review my code, give me any criticism, inform me of any optimizations I'm missing out on, etc. I don't really care for "Perl golf"-style code, but I do care about optimized, neat code. Readability is important.

Thanks in advance!

Updated as of 3:11 PM EDT.

#!/usr/bin/perl -w use strict; open(my $fh, "<", $ARGV[0]) or die "cannot open input file: $!"; my @words = <$fh>; close $fh or die "cannot close input file: $!"; my $words = @words; chomp(my $word = lc($words[int(rand($words))])); my (%correct, $guesses); my $turns = 8; while ($turns > 0) { my $displayed; foreach my $char (split(//, $word)) { $displayed .= exists($correct{$char}) ? "$char " : "* "; } if (index($displayed, "*") < 0) { print "\nYou win! You guessed $word!\n"; exit; } print "\n$displayed\n", "Fails remaining: $turns\n", "Your guesses: $guesses\n", "Next guess: "; chomp(my $guess = <STDIN>); $guess = lc($guess); if ($guess !~ /[a-z]/ || length($guess) != 1 || index($guesses, $g +uess) >= 0) { print "\nInvalid guess.\n"; } else { my %word = map { $_ => 1 } split(//, $word); if (exists($word{$guess})) { $correct{$guess}++; } else { $turns--; } $guesses .= "$guess "; } } print "\nYou lost! The word was $word!\n";

In reply to Looking for pointers or optimizations. by thmsdrew

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?

    What's my password?
    Create A New User
    and all is quiet...

    How do I use this? | Other CB clients
    Other Users?
    Others examining the Monastery: (5)
    As of 2018-06-17 22:30 GMT
    Find Nodes?
      Voting Booth?
      Should cpanminus be part of the standard Perl release?

      Results (107 votes). Check out past polls.