in reply to Re: A refactoring trap
in thread A refactoring trap

The second while however, will stop as soon as it finds an empty line

Just to test your assertion:

while (my $line = <DATA>) {print $line}; __DATA__ one two three four

results in




It seems that empty lines don't break the loop at all.

Replies are listed 'Best First'.
Re^3: A refactoring trap
by redlemon (Hermit) on Aug 17, 2005 at 08:14 UTC

    Hmmm, you're right. It doesn't break.

    The reason is that blank lines are not truely blank, of course. You're saved by the fact that a blank line still contains the "\n".


      No it still works with chomp:
      while(chomp (my $line = <DATA>)){
      At least with newer perl versions. Tried with perl5.8.6.
        No it still works with chomp

        To understand why this works, take a look at the return value for chomp. Hint: it's not the string with newlines missing.

        The problem with while (my $line = <DATA>) {} is real, it's just obscure. As hinted, it only happens when you get a line with a false value and no newline. Sometimes this happens at the end of a file. Sometimes it happens for other reasons. It usually doesn't cause any actual problems, but certainly is something to look out for.

        With this method you'll never be able to loop through the last line.