We use scripts like this for some other service-type applications on our system (though not necessarily via /etc/rc.d) a LOT. A lot of applications make the assumption that one or two instances of a given application will be installed, so they give you one 'admin' script for each instance and you issue a set of start/stop/status type commands to run it. Since we have dozens of instances running, this can be painful, so like you, we've set up scripts that reverse the order of the action. Instead of telling instance X to start, we "start" instance X.
I might suggest the following changes:
my $service = shift;
my ($action) = $0 =~ m![^/]+)$!; # corrected per reply
$service =~ tr~/~~d;
die "$service: No such service" unless -x "/etc/rc.d/init.d/$service"
+&& -f _;
exec("/etc/rc.d/init.d/$service", $action) or die "exec: $!";
By using the multi-argument form of exec
for that matter), we don't have to worry about shell metacharacters mucking us up. This is probably reasonably safe to run set-uid or via sudo.
Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
Want more info? How to link or
or How to display code and escape characters
are good places to start.