Duplicated (non-trivial) code should be extracted into subroutines. For example:
could become a function.
As a matter of personal taste, I'd turn
->hb_Local_spoils == 0);
into a function. When I encounter a "next if", I don't want to dwell on the logic of the test, but to simply note that a
Finally (and again, this is all just personal taste), consider changing
$total_lodged = $_->qcs_document_count() - $client_job_spoil->hb_Loc
It takes fewer lines and (if you align equal signs and operations) should be just as readable, if not more.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] |