I know it's not a big issue, but personally i don't like to put variables captured in between quotes like this:my $message = "<event id=\"ALERT_$tier_$code1\" source=\"APP\">";
I do think it's better maintainable, readable etc. if you concatenate strings like this:
my $message = "<event id=\"ALERT_" . $tier . "_" . $code1 . "\" source=\"APP\">";
As you immediately see in the last line, the $tier and $code1 are Perl variables, as you don't see that as fast in your given one.
update: or indeed use grandfather
update2: I have to agree to davidrw
works even more clean.
I have to admit as well, that i don't use it that often, even though it's a great function for string formatting, and i really don't know why.
Perhaps i need to force myself a bit more :).
"We all agree on the necessity of compromise. We just can't agree on when it's necessary to compromise." - Larry Wall.