in reply to Re: Fixing an XS based dist
in thread Fixing an XS based dist

While I agree on the "Right things", I've been down that road. The current culture is mostly "we accept patches" with a side of "win32 suxOrs"; not from the author though.

With that said, it DID pass its test suite, so it's certainly no more broken now than any other version of itself on any other platform at this point.

Replies are listed 'Best First'.
Re^3: Fixing an XS based dist
by gellyfish (Monsignor) on Aug 09, 2005 at 20:36 UTC

    Well it might not be passing its test suite or even building on any other platform unless you have built and tested on a variety of other platforms. The best way to go is to supply the output of diff -u <original_file> <changed_file> so that others can apply the patch and test on a variety of platforms.


      Very true. I guess the same could be said for any (non c) change as well. Oh my kindom to have every platform at home to test on...wait I do. :-)

      I give it a shot on FreeBSD this evening. That should prove to be interesting.