Beefy Boxes and Bandwidth Generously Provided by pair Networks
Your skill will accomplish
what the force of many cannot

Re^2: Iterator to parse multiline string with \\n terminator

by three18ti (Scribe)
on Oct 06, 2013 at 09:20 UTC ( #1057134=note: print w/replies, xml ) Need Help??

in reply to Re: Iterator to parse multiline string with \\n terminator
in thread Iterator to parse multiline string with \\n terminator

WRT your edit

What do you think about a return instead of an if? e.g.:

sub fh_iterator { my $fh = shift; my $line = $fh->getline(); return $line unless $line; $line .= $fh->getline() while $line =~ m{\\$}; return $line; }

I don't think there's any functional difference, but one may be more readable than the other...

Thanks for your help!

Replies are listed 'Best First'.
Re^3: Iterator to parse multiline string with \\n terminator
by tinita (Parson) on Oct 06, 2013 at 12:46 UTC
    return $line unless $line;
    make that:
    return $line unless defined $line;
    theoretically the last line could be missing the newline and only contain "0". then $line would be false and ignored with your code.
Re^3: Iterator to parse multiline string with \\n terminator
by Athanasius (Bishop) on Oct 06, 2013 at 16:28 UTC

    ++tinita for highlighting the important difference between testing for definedness and testing for truth (see perlsyn#Truth-and-Falsehood).

    But even with the correction I prefer my version. Readability is in the eye of the programmer, but the first high-level programming subject I took at Uni (in Pascal!) emphasised structured programming, and this has remained with me. I prefer a function to have a single exit point (at the end) where possible. In Perl this is not always optimum, so I’ve had to learn to be flexible. But when — as in this case — the structured version is as straightforward as the non-structured one, I prefer the former. YMMV.

    As always in Perl, TMTOWTDI.

    Athanasius <°(((><contra mundum Iustus alius egestas vitae, eros Piratica,

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1057134]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others imbibing at the Monastery: (2)
As of 2019-04-21 08:40 GMT
Find Nodes?
    Voting Booth?
    I am most likely to install a new module from CPAN if:

    Results (110 votes). Check out past polls.

    • (Sep 10, 2018 at 22:53 UTC) Welcome new users!