Beefy Boxes and Bandwidth Generously Provided by pair Networks
good chemistry is complicated,
and a little bit messy -LW
 
PerlMonks  

Re: Mapping list to hash is dropping list items

by eyepopslikeamosquito (Bishop)
on Mar 13, 2022 at 11:18 UTC ( #11142067=note: print w/replies, xml ) Need Help??


in reply to Mapping list to hash is dropping list items

G'day almsdealer,

Welcome to the Monastery.

Given you're very new to Perl, you've made a great start! Though you're problem has already been solved (by the redoubtable haukex) I'd like to offer a couple of tips to help you on your Perl journey:

  • Always use parens when calling user-defined subroutines (see here for why).
  • Use Perl's core B::Deparse module to see how Perl parses your script.

For example, with your script saved as almsdealer.pl, running:

perl -MO=Deparse,-p almsdealer.pl >deparse.pl
allows you to see how Perl parses your script, in your case deparse.pl contains:
use strict; use warnings; sub myTrim { (my($str) = @_); (my($trimmed) = ($str =~ /\s*(.*)\s*/)); (return $trimmed); } (my(@allTags) = ()); foreach my $file (glob('[0-9][0-9][0-9][0-9].txt')) { use File::Glob (); (my(@fileTags) = ()); (open(my $handle, '<', $file) or die(q[couldn't open file])); while (defined((my $line = readline($handle)))) { do { if (($line =~ /^tags/)) { (my($tagsString) = ($line =~ /^tags\s+(.*)/)); (@fileTags = (@fileTags, split(/,/, $tagsString, 0))); } }; } close($handle); (my(%uniqueTags) = map({myTrim($_, 1);} @fileTags)); (@allTags = (@allTags, keys(%uniqueTags))); } print(("@allTags\n"));

Hopefully, seeing myTrim($_, 1) will set alarm bells ringing because your myTrim function takes one argument, not two.

As a matter of personal style, I would write your:

my ($str) = @_;
as:
my $str = shift; # the string to be trimmed
because I like to put a comment next to each parameter describing what it does, plus this style scales nicely for subroutines that take more than one argument (a random example of this style can be found here).

Replies are listed 'Best First'.
Re^2: Mapping list to hash is dropping list items
by almsdealer (Acolyte) on Mar 13, 2022 at 13:52 UTC
    Wow, thank you. What a wealth of information I've gained just from all the replies in this thread!

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://11142067]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others musing on the Monastery: (8)
As of 2023-02-03 14:25 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    I prefer not to run the latest version of Perl because:







    Results (26 votes). Check out past polls.

    Notices?