Beefy Boxes and Bandwidth Generously Provided by pair Networks
more useful options
 
PerlMonks  

Re: Editing your writeup is now a separate action from viewing a thread and voting on replies (no cat ans edit)

by tye (Sage)
on Jun 15, 2016 at 02:49 UTC ( #1165677=note: print w/replies, xml ) Need Help??


in reply to Editing your writeup is now a separate action from viewing a thread and voting on replies

There is another bug resulting from this work. You can no longer edit a categorized answer since the 'editinvote' element no longer actually allows 'edit'. Adding an "edit" link will not solve this particular problem because of the hokey way CatQ+A was implemented (an "edit" link would just send you to the "Permission Denied" page).

Note even the new option at the end of display settings works around this problem.

- tye        

  • Comment on Re: Editing your writeup is now a separate action from viewing a thread and voting on replies (no cat ans edit)

Replies are listed 'Best First'.
Re^2: Editing your writeup is now a separate action from viewing a thread and voting on replies (no cat ans edit)
by jdporter (Canon) on Jun 15, 2016 at 15:42 UTC

    Thanks. I will fix.

    Note even the new option

    I'm not sure how to parse that. Did you mean "not"? I was able to edit a CatQ and a CatA by using the new option to "edit in display".

    (Hold on... It may be because I'm in QandAEditors.)

    On further reflection... Did this ever work? I thought that once a monk submitted a CatQ/A, it became owned by QandAEditors and was no longer editable by the submittor. No?

    I reckon we are the only monastery ever to have a dungeon stuffed with 16,000 zombies.

      Sorry, yes, "Note" should have been "Not" as you guessed.

      I'm not absolutely sure, but I believe that the old state was that when you looked at "your" submissions, you could edit them directly (even through they were not "owned" by you). I'm pretty sure that people have been editing those w/o having to ask Q+A Editors to do it for them.

      Perhaps somebody who has tried that more recently than I could chime in (but tried before these recent changes).

      So my guess is that there was code in 'editinvote' (or somewhere) that honored original_author not just author_user.

      - tye        

        I've only looked into categorized answer display page so far; it uses editinvote whereas categorized question display page does not, and never has.

        It looks to me like editinvote depends, and has always depended, solely on canUpdateNode for its authorization check. And canUpdateNode does not -- and I guess never has -- accounted for $NODE->{original_author}. So I'm pretty sure I was right, at least as regards CatA nodes.

        And given that, I'm also comfortable in my confidence that it was also the case for CatQ nodes.

        Further investigation (which was surprisingly tough; very little seems to have been said on the specific point of the editability of CatQ/A by original author) -- I found:

        • This old Editor Request, which was asking for an edit to a CatA -- which wouldn't have been necessary if the author could have edited it himself.
        • This old PMD subthread, in which monks discuss the idea of opening up CatQ/A nodes to editing by author. vroom (and others) explain why it was not done that way.

        I reckon we are the only monastery ever to have a dungeon stuffed with 16,000 zombies.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1165677]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others chilling in the Monastery: (4)
As of 2019-12-15 12:26 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found

    Notices?