Beefy Boxes and Bandwidth Generously Provided by pair Networks
Your skill will accomplish
what the force of many cannot
 
PerlMonks  

Re: Missing "Vote" button

by Athanasius (Archbishop)
on Nov 18, 2017 at 07:43 UTC ( [id://1203719]=note: print w/replies, xml ) Need Help??


in reply to Missing "Vote" button

All nodes in the current Book Reviews thread Modern Perl 4th Edition have radio buttons for voting, but the thread has no Vote button.

Athanasius <°(((><contra mundum Iustus alius egestas vitae, eros Piratica,

Replies are listed 'Best First'.
Re^2: Missing "Vote" button
by LanX (Saint) on Nov 18, 2017 at 12:21 UTC
    That's not entirely correct, you can vote on the replies if you open them individually, like Re: Modern Perl 4th Edition .

    I looked into the code yesterday, and review display page lacks inclusion of votehead and votefoot to include the form and submit button.

    There are recent patches mentioning voteit from jdporter, but I have trouble grasping them.

    I could create new patches, but I'd like to first discuss them with jdporter, who is absent at the moment.

    Understanding the monastery mechanics is not straight forward. ..

    Cheers Rolf
    (addicted to the Perl Programming Language and ☆☆☆☆ :)
    Je suis Charlie!

    update

    Added deeplinks into the code which are only accessible for some cabal

      That's not entirely correct, you can vote on the replies if you open them individually.

      I think Athanasius may have meant exactly that: you can vote on the replies only, but not on the thread's first node Modern Perl 4th Edition/1203697 itself.

      At least that is what I have understood.

      Cheers, Sören

      Créateur des bugs mobiles - let loose once, run everywhere.
      (hooked on the Perl Programming language)

      > I looked into the code yesterday, and review display page lacks inclusion of votehead and votefoot to include the form and submit button.

      I submitted a patch which should fix it for reviews , let's see what happens after the gods applied it.

      I can only guess that jdporter planned some refactoring in March 2016, but I wasn't able to locate the "voteformcontainer" he's mentioning.

      Cheers Rolf
      (addicted to the Perl Programming Language and ☆☆☆☆ :)
      Je suis Charlie!

        I submitted a patch which should fix it for reviews

        Thanks for that.
        Just yesterday, I got suckered again - different thread, but same issue.

        Cheers,
        Rob

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://1203719]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others rifling through the Monastery: (5)
As of 2024-04-23 18:59 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found