Beefy Boxes and Bandwidth Generously Provided by pair Networks
There's more than one way to do things
 
PerlMonks  

Re: poor quality perl code

by dsheroh (Prior)
on Mar 22, 2018 at 08:45 UTC ( #1211495=note: print w/replies, xml ) Need Help??


in reply to poor quality perl code

What exactly do you mean to be the Perl equivalent of "stringly typed" coding? Passing comma-delimited strings instead of arrays? Because "passing a string where you should use a float instead" doesn't really apply to a language where "a scalar is a scalar is a scalar", regardless of whether that scalar is a string or a number or even both at the same time.

As for the actual question, my approach to similar situations is to try to show better ways of doing it (TIMTOWTDI, but not all ways are equally good!) and explain why they're better. That doesn't really work with typographical conventions for names, though, so I think you'll just have to go for the "this is the standard convention" angle and hope for the best.

Replies are listed 'Best First'.
Re^2: poor quality perl code
by pwagyi (Scribe) on Mar 23, 2018 at 01:12 UTC

    It's the former case, passing '|' delimited string instead of returning hash. (eg. apple|red|3.0 instead of ( fruit => 'apple', color => 'red', weight => 3.0) Using datetime as string in the whole code. Oh and I have witnessed a subroutine with 22 (positional) arguments!

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1211495]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (9)
As of 2019-10-15 12:24 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    Notices?